Add support for forward and back mouse buttons #1919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This MR should partly fix #1920, but only on chromium. |
CendioHalim
force-pushed
the
extra-mouse-buttons
branch
from
897d269 to
e3195f7
Compare
CendioOssman
requested changes
Nov 28, 2024
core/rfb.js
Outdated
Comment on lines
1067
to
1068
| * NOTE: This only works on chromium-based browsers. There is | ||
| * no support for firefox/safari. |
There was a problem hiding this comment.
Strictly speaking, Safari has buggy support rather than no support. Right?
There was a problem hiding this comment.
Correct.
I just realized that safari send the incorrect ev.button value, but the button mask ev.buttons seems to work correctly. With back pressed, ev.buttons is 8, and with forward pressed, it is 16.
We could look at those instead of keeping mouse button state ourselves?
| it('should send correct data for extended pointer events', function () { | ||
| RFB.messages.extendedPointerEvent(sock, 12345, 54321, 0xab); | ||
| let expected = | ||
| [ 5, 0xab, 0x30, 0x39, 0xd4, 0x31, 0x01]; | ||
| expect(sock).to.have.sent(new Uint8Array(expected)); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
We'd also like tests for the interaction with the pseudo-encoding and pseudo-rect.
| [ 5, 0xab, 0x30, 0x39, 0xd4, 0x31]; | ||
| [ 5, 0x2b, 0x30, 0x39, 0xd4, 0x31]; | ||
| expect(sock).to.have.sent(new Uint8Array(expected)); | ||
| }); |
There was a problem hiding this comment.
The masking should probably be tested as an explicitly different test.
Instead of keeping track of button states ourselves by looking at MouseEvent.button, we can use the MouseEvent.buttons which already contains the state of all buttons.
This commit implements the extendedMouseButtons pseudo-encoding, which makes it possible to use the forward and back mouse buttons.
CendioHalim
force-pushed
the
extra-mouse-buttons
branch
from
e3195f7 to
dc170dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the extendedMouseButtons pseudo-encoding, which makes it possible to use the forward and back mouse buttons.
It looks like chromium is the only browser that has support for this currently. See #1918 for more info.
Confirmed that it works with chromium on Mac, Linux and Windows against TigerVNC server.